Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: compute WeekView width dinamically #189

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

pdpino
Copy link
Collaborator

@pdpino pdpino commented Apr 12, 2022

Main changes:

  • Remove hard-coded CONTAINER_WIDTH variable
  • Calculate dynamically dimensions = { dayWidth, pageWidth, timeLabelsWidth } to define the widths of the views

This refactor will allow solving later:

@pdpino pdpino added type: bug type: feature enhancements or new features labels Apr 12, 2022
@hoangnm
Copy link
Owner

hoangnm commented Apr 24, 2022

So is this PR a baseline for the later improvements, @pdpino ?

@pdpino
Copy link
Collaborator Author

pdpino commented Apr 24, 2022

So is this PR a baseline for the later improvements

Yes @hoangnm

@hoangnm
Copy link
Owner

hoangnm commented Apr 24, 2022

Thank @pdpino , it looks promising!

@hoangnm hoangnm merged commit 6003f1c into hoangnm:master Apr 24, 2022
@rdewolff
Copy link

I have noticed the component is not displayed properly on a browser when using react-native-web. Have you checked it?

@pdpino pdpino deleted the refactor/adjust-width branch April 25, 2022 09:45
@pdpino
Copy link
Collaborator Author

pdpino commented Apr 25, 2022

@rdewolff We haven't checked in react-native-web.

Could you open a different issue with this, and show a screenshot or video with the error?

@rdewolff
Copy link

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: feature enhancements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants