Improve/fix drag-and-drop #175
Conversation
Leave out event-press and grid-press for now
Leave out grid touches for now
Create ViewWithTouchable, patches TouchableWithoutFeedback from RNGH Reduce from multiple touchables to just one touchable per week
Do not recreate callbacks in each render Names used: "handleX" for component methods, "onX" for props
(only the issues introduced in this PR)
Use standard name
pdpino
added
status: PR - ready
priority: high
and removed
status: on hold
Mention breaking change in changelog Tab formatting in readme (automatic)
|
Hi @pdpino, I tried to run on local but the calendar is frozen and I couldn't perform any action, anything specific I need to set up when running on local? |
|
nvm, I can make it work now. |
|
@hoangnm only installing peer dependencies react-native-gesture-handler v2 and react-native-reanimated v2, following their instructions |
src/__tests__/Event.test.js
Outdated
| expect(onDragMock).toHaveBeenCalledWith( | ||
| mockEvent, | ||
| position.left + position.width / 2 + 7, | ||
| position.top + 52, |
There was a problem hiding this comment.
can we have a clear naming for these values?
|
Drag & drop are really smoother, this would be a great improvement. |
Improve ViewWithTouchable docs Remove unnecessary key
|
I'm thinking to use this feature as a version 2 and I'll bump the current code base to v1. |
|
Are we following semver?
I suggest we stay in version 0.x, we can still make some breaking changes |
|
yes, there's a FAQ https://semver.org/#how-do-i-know-when-to-release-100 and I think that recommendation makes sense for our case. WDYT, @pdpino ? |
|
Some users might be using in production: yes But I think the API might still change, e.g. some props:
I prefer keeping 0.x and finish some of these new features first |
|
ok @pdpino , that makes sense. |
|
Great PR, thank @pdpino , merging. |
Fixes #154
Lmk what you think!