Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hfClient to v1 to include Namespaces #4

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

caylorme
Copy link
Contributor

@caylorme caylorme commented Nov 7, 2023

Currently, hfcli is not passing the namespace parameter to the underlying hobbyfarm api calls.
This PR updates the hobby farm client to v1 which enables namespace parameters to the underlying resource operations.

@eengelking
Copy link

I've tested this and was able to get the scenario to download, whereas before it didn't work.

➜ ./hfcli get scenario s-kphtuenlbk ./s-kphtuenlbk -k ~/.kube/k3s.yaml -n hobbyfarm-system
INFO[0000] s-kphtuenlbk./s-kphtuenlbk                   
INFO[0000] downloading scenario s-kphtuenlbk            
INFO[0000] writing scenario Q29udGFpbmVyIEJhc2ljcyAtIExhYiAx to /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk 
INFO[0000] creating scenario.yml                        
INFO[0000] creating step /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk/content/step-1.md 
INFO[0000] creating step /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk/content/step-2.md 
INFO[0000] creating step /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk/content/step-3.md 
INFO[0000] creating step /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk/content/step-4.md 
INFO[0000] creating step /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk/content/step-5.md 
INFO[0000] creating step /home/eengelking/git/github/hobbyfarm/hfcli-jason/s-kphtuenlbk/content/step-6.md 

@caylorme caylorme mentioned this pull request Nov 8, 2023
@ebauman ebauman merged commit 9fa221d into hobbyfarm:main Nov 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants