Merge pull request #28 from grummbeer/add-missig-key

Add missing attribute 'rel=“noreferrer noopener”' for external links if target = “_blank”
hofff · Sep 23, 2024 · a0627e9 · a0627e9
2 parents 74c21f1 + 80340e1
commit a0627e9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/Renderer/NavigationRenderer.php b/src/Renderer/NavigationRenderer.php
@@ -267,6 +267,7 @@ private function compileNavigationItem(array $page, bool $forwardResolution = tr
         $page['title']       = StringUtil::specialchars($page['_title'], true);
         $page['pageTitle']   = StringUtil::specialchars($page['_pageTitle'], true);
         $page['target']      = ''; // overwrite DB value
+        $page['rel']         = '';
         $page['nofollow']    = strncmp($page['robots'], 'noindex', 7) === 0;
         $page['description'] = str_replace(["\n", "\r"], [' ', ''], $page['_description']);
         $page['isInTrail']   = $this->items->isInTrail((int) $page['id']);
@@ -280,6 +281,10 @@ private function compileNavigationItem(array $page, bool $forwardResolution = tr
                     } elseif ($redirectPage['type'] === 'redirect') {
                         $page['href']   = $this->encodeEmailURL($redirectPage['url']);
                         $page['target'] = $redirectPage['target'] ? 'target="_blank"' : '';
+
+                        if ('target="_blank"' === $page['target']) {
+                            $page['rel'] = 'rel="noreferrer noopener"';
+                        }
                     } else {
                         $page['tid']  = $redirectPage['id'];
                         $page['href'] = $this->generatePageUrl($redirectPage);
@@ -294,6 +299,10 @@ private function compileNavigationItem(array $page, bool $forwardResolution = tr
             case 'redirect':
                 $page['href']   = $this->encodeEmailURL($page['url']);
                 $page['target'] = $page['_target'] ? 'target="_blank"' : '';
+
+                if ('target="_blank"' === $page['target']) {
+                    $page['rel'] = 'rel="noreferrer noopener"';
+                }
                 break;
 
             case 'root':

diff --git a/src/Resources/contao/templates/nav_hofff.html5 b/src/Resources/contao/templates/nav_hofff.html5
@@ -8,6 +8,7 @@
       <?php if($item['tabindex'] ?? null): ?>tabindex="<?php echo $item['tabindex']; ?>"<?php endif; ?>
       <?php if($item['isActive']): ?>rel="nofollow"<?php endif; ?>
       <?php echo $item['target']; ?>
+      <?php echo $item['rel'] ?>
     ><?php echo $item['link'];
   ?></a
   ><?php echo $item['subitems'];