-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File-like objects support #102
Comments
The last time I looked into this I ran into problems passing a FILE like object to the C extension that we are wrapping ( Please feel free to open a PR. I think it should in principle not a huge change, however, it could be tricky to pass the buffer handle in a format that is understood in C. If you find a way to do this, let me know. My quick google/stackoverflow has also not led me to a solution that supports Python native generic IO file-like buffers. |
Not sure that I have enough skills of Cython to dig into this problem nor time to research it... But I'd like to do it one time. I also mentioned that the lib prints loading progress, is it possible to disable? I'd like to keep the console output clean :) |
Some functions have the If you need any help with the PR let me know - for now I just need an option to send a generic Python IO object to C, and make the C pyedflib/pyedflib/_extensions/c/edflib.c Line 5295 in 73cab5e
|
My C skills aren't very sharp, but I might be able to write a backend in Python that supports this. Any desire to support a Python backend for parsing or do you only want to support the C backend? |
As far as I remember there is already a Python implementation of On the flip side the advantage was so far that we did not have to maintain the backend ourselves and could just merge bugfixes etc from Having a backend that is equally fast and reliable in Python/Cython would be great, however, I fear that it will be more work than expected. There are quite a few corner cases that need to be covered and so far |
Hi! Thanks for the lib and making the world better 😊
As I can see, for now pyedflib only works with file paths, so it isn't able to read/write in memory file-like objects, e.g BytesIO? If so, it is a huge lack!
The text was updated successfully, but these errors were encountered: