Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cython 3 #248

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Support Cython 3 #248

merged 2 commits into from
Nov 12, 2023

Conversation

musicinmybrain
Copy link
Contributor

Fix a relative cimport and revert the commit that pinned cython<3.0.

@skjerns
Copy link
Collaborator

skjerns commented Nov 11, 2023

I assume #233 and #234 has been fixed?

@musicinmybrain
Copy link
Contributor Author

I assume #233 and #234 has been fixed?

Yes, I found that everything was fine (it compiled and the tests passed) after I fixed the cimport:

      cimport c_edf
              ^
      ------------------------------------------------------------
      
      pyedflib/_extensions/_pyedflib.pyx:24:8: 'c_edf.pxd' not found

@skjerns
Copy link
Collaborator

skjerns commented Nov 12, 2023

Strange, I could have sworn that I tried that.

Thanks! That fixes it :)

@skjerns skjerns merged commit 3bbcdc0 into holgern:master Nov 12, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants