New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to main APIs #264

Merged

skjerns merged 22 commits into holgern:master from joseph-pq:typehints

Nov 13, 2024

Contributor

joseph-pq commented Oct 19, 2024

Related Issues

Changes

Added typehints to files:

edfreader.py
edfwriter.py
highleve.py

Also, I added a py.typed file for being recognizable for mypy and a _pyedflib.pyi as a python interface for the _pyedflib.pyc.

joseph-pq added 5 commits

October 15, 2024 10:28


          add py.typed

190e053


          add typehints in edfreader.py

21fa839


          add _extensions/_pyedflib.pyi

6db40a4


          add typehints in edfwriter

ae5c734


          add typehints in highlevel.py

14de789

skjerns reviewed

View reviewed changes

pyedflib/highlevel.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/highlevel.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/highlevel.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/highlevel.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/highlevel.py Outdated Show resolved Hide resolved

joseph-pq and others added 5 commits

November 9, 2024 10:04


          Update typehint of sample_rate and sample_frequency

Co-authored-by: Simon Kern <[email protected]>


          Updated type hint digital_min and digital_max

7a529c0

Co-authored-by: Simon Kern <[email protected]>


          Update typehint sample_frequency

52058f8

Co-authored-by: Simon Kern <[email protected]>


          Update pyedflib/highlevel.py

ee5152e

Co-authored-by: Simon Kern <[email protected]>


          Update typehint sfreq

67ab140

Co-authored-by: Simon Kern <[email protected]>

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfwriter.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfreader.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfreader.py Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfreader.py Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfreader.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfreader.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/edfreader.py Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/_extensions/_pyedflib.pyi Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

pyedflib/_extensions/_pyedflib.pyi Outdated Show resolved Hide resolved

skjerns reviewed

View reviewed changes

Collaborator

skjerns left a comment

Thanks! looking good :) if you implement the changes, I will merge

joseph-pq and others added 10 commits

November 12, 2024 13:50


          Apply suggestions from code review

3436c38

Co-authored-by: Simon Kern <[email protected]>


          Apply suggestions from code review

10a1e43

Co-authored-by: Simon Kern <[email protected]>


          Apply suggestions from code review

c3a792c

Co-authored-by: Simon Kern <[email protected]>


          Add TracebackType in edfreader.py

386b298


          Add TracebackType edfwriter.py

364d9c0


          Apply suggestions from code review

6669b17

Co-authored-by: Simon Kern <[email protected]>


          Add Type in edfreader.py

ea33d96


          Add Type in edfwriter.py

ab6cd43


          Update edfreader.py

3062dcf


          Update pyedflib/edfreader.py

30c2067

Co-authored-by: Simon Kern <[email protected]>

joseph-pq commented

View reviewed changes

Contributor Author

joseph-pq left a comment

@skjerns I accepted most of the suggestions. I responded to the rest.

Collaborator

skjerns commented Nov 13, 2024

@joseph-pq there seems to be a syntax error, could you check?

Collaborator

skjerns commented Nov 13, 2024

@holgern could you enable squash and merge as the default for the repo settings?

joseph-pq added 2 commits

November 13, 2024 09:48


          fix syntax errors

3413d1a


          fix syntax error

637f1bf

skjerns merged commit ea9ee94 into holgern:master

32 checks passed

Collaborator

skjerns commented Nov 13, 2024

thanks to @joseph-pq for the great PR, will merge

joseph-pq deleted the typehints branch

November 13, 2024 14:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet