Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssl_ca_path to jabber connection. #526

Merged
merged 1 commit into from
Nov 8, 2015
Merged

Conversation

tobser
Copy link
Contributor

@tobser tobser commented Jul 27, 2015

this is needed for newer perl setups, I'm using 5.22,not sure if this
will break older setups..

this is needed for newer perl setups, i'm using 5.22,not sure if this
will break older setups..
@hollie
Copy link
Owner

hollie commented Jul 27, 2015

Hey Tobi,

thanks for the patch. In case somebody does not have the 'net_jabber_certs_path' setting in the mh.private.ini and the folder /etc/ssl/certs/ does not exist, will this work or error out?

Best regards,
Lieven.

@tobser
Copy link
Contributor Author

tobser commented Jul 28, 2015

The path '/etc/ssl/certs' comes from openssl and it seems like most linux distributions have it, or it is a symlink to another valid path.
I have no idea if the parameter has any effect on Windows...

If the folder does not exist, the same error occurs as if the ssl_ca_path parameter was not set at all:

2015-07-28 16:05:24: Invalid or unreadable path specified for ssl_ca_path. at /usr/lib/perl5/vendor_perl/5.22.0/XML/Stream.pm line 641.
 at ./mh line 31.
        main::__ANON__("Invalid or unreadable path specified for ssl_ca_path. at /usr"...) called at /usr/lib/perl5/vendor_perl/5.22.0/XML/Stream.pm line 641
        XML::Stream::Connect(XML::Stream=HASH(0x9d52f28)) called at /usr/local/lib/perl5/5.22.0/Net/XMPP/Connection.pm line 177
        Net::XMPP::Connection::Connect(Net::Jabber::Client=HASH(0x9d55a58)) called at ../lib/handy_net_utilities.pl line 382
        main::net_jabber_signon(undef, undef) called at ../lib/handy_net_utilities.pl line 643
        main::net_im_signon(undef, undef, "jabber") called at (eval 396) line 1331
        main::internet_im_loopcode() called at (eval 396) line 4005
        main::loop_code called at (eval 712) line 1
Line 1326:                                  # Allow for auto-connect on startup (otherwise connects only when sending)
Line 1327:      if ($Startup) {
Line 1328:          &net_im_signon(undef, undef, 'aim')    if $config_parms{net_aim_autoconnect};
Line 1329:          &net_im_signon(undef, undef, 'msn')    if $config_parms{net_msn_autoconnect};
Line 1330:          &net_im_signon(undef, undef, 'icq')    if $config_parms{net_icq_autoconnect};
Line 1331:          &net_im_signon(undef, undef, 'jabber') if $config_parms{net_jabber_autoconnect};
Line 1332:      }
Line 1333:

@hollie
Copy link
Owner

hollie commented Nov 8, 2015

Hey @tobser, sorry it took so long to come back on this.

I'll merge your pull request.

hollie added a commit that referenced this pull request Nov 8, 2015
Add ssl_ca_path to jabber connection.
@hollie hollie merged commit d3e8649 into hollie:master Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants