Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plcbus scenesupport #579

Merged
merged 4 commits into from
Mar 27, 2016
Merged

Plcbus scenesupport #579

merged 4 commits into from
Mar 27, 2016

Conversation

tobser
Copy link
Contributor

@tobser tobser commented Mar 9, 2016

This adds support to program/delete/use scene addresses

Tobias Sachs added 3 commits March 7, 2016 09:46
each light bulb has a diffrent brightness behaviour, so more smaller
steps are needed.
@@ -626,6 +626,7 @@ sub _check_external_plcbus_command_file() {
my $filename = $::config_parms{plcbus_command_file};
return unless $filename;
return unless $::New_Second;
return unless $::New_Second;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason we need this statement twice here?

@hollie
Copy link
Owner

hollie commented Mar 20, 2016

Hey @tobser thanks for the update.

I have no problems merging this, just a small question: why did you duplicate the return unless New_second in the code at line 629?

Regards,
Lieven.

@tobser
Copy link
Contributor Author

tobser commented Mar 21, 2016

Hey Lieven,
thanks for the notice. I must have duplicated the line by accident
without noticing...
I removed the duplicate line and pushed the change.

Regards,
Tobi

Am 20.03.2016 um 22:37 schrieb Lieven Hollevoet:

Hey @tobser https://github.com/tobser thanks for the update.

I have no problems merging this, just a small question: why did you
duplicate the return unless New_second in the code at line 629?

Regards,
Lieven.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#579 (comment)

@hollie
Copy link
Owner

hollie commented Mar 27, 2016

Hallo Tobi,

perfekt, vielen Dank!

Lieven.

@hollie hollie merged commit e91e041 into hollie:master Mar 27, 2016
@tobser tobser deleted the plcbus-scenesupport branch May 9, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants