Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows the control of WGL rain8Net serial sprinkler control modules #590

Merged
merged 3 commits into from
May 12, 2016

Conversation

madman1968
Copy link
Contributor

@madman1968
Copy link
Contributor Author

Updates fff2dbe and a5cc6d2 relate to PushOver.pm module to support html and device parameters on the API call.

@hollie
Copy link
Owner

hollie commented May 12, 2016

Hello Marco,

I merged your pull request, only to see after the merge that you created the pull request against the stable branch. The stable branch is used to distribute stable versions and not for active development.

So, I reverted the pull request/merge and I'd like to ask you to create a new pull request with your changes against the master branch. More details on how to do this is documented in the wiki, see https://github.com/hollie/misterhouse/wiki/Contributing#creating-a-pull-request-for-new-contributors.

While you do so, could you please split the contribution for Rain8 and the one with the changes for pushover into two separate pull request?

Thanks a lot,
Lieven.

@madman1968
Copy link
Contributor Author

Hi Lieven
Thanks first of all for the work on misterhouse and thanks for your patience regarding my pull request. I have followed the wiki and hopefully done it correctly now. Request #595 is opened with just the Rain8Net module.

If that turns out ok, I will create a future pullrequest in a different branch for the Pushover module.

Marco

@hollie
Copy link
Owner

hollie commented May 20, 2016

Hey Marco,

thank you for submitting the new pull request. Looks all fine and dandy, I've already merged it into master.

Kind regards,
Lieven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants