Json server fixes

[waynieack]

Fix for rrd file path not being pulled from rrd_dir and weather_data_rrd ini params by default in json_server.pl. Also fixed an issue which can cause MH to crash.

[hollie]

Thanks for this pull request!

[hplato]

Since were changing the default weather RRD name, we should to check what name gets created on a fresh install.

I also thought it might be nice to have a JSON option to pass another rrd as an option. This could be useful for folks that have more than one RRD on their system

•    my $rrd_file = "weather.rrd";
  

•    my $rrd_file = "weather_data.rrd";
  

[waynieack]

weather_data.rrd is the default on a new install with no config settings, just tested with my dev system and weather_rrd_update.pl. I left the json config setting that was already there as the last option so it will override the mh.private.ini if its configured, is that what you mean? my $rrd_file = "weather_data.rrd"; $rrd_file = $config_parms{weather_data_rrd} if ( defined $config_parms{weather_data_rrd} ); if ( $rrd_file =~ m/.*\/(.*\.rrd)/ ) { $rrd_file = $1; } $rrd_file = $json_data{'rrd_config'}->{'prefs'}->{'default_rrd'} if ( defined $json_data{'rrd_config'}->{'prefs'}->{'default_rrd'} ); _Wayne

…

On Sat, Dec 17, 2016 at 2:54 PM, hplato ***@***.***> wrote: Since were changing the default weather RRD name, we should to check what name gets created on a fresh install. I also thought it might be nice to have a JSON option to pass another rrd as an option. This could be useful for folks that have more than one RRD on their system - my $rrd_file = "weather.rrd"; - my $rrd_file = "weather_data.rrd"; — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#649 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFZ3ea466bsklHq06IQmJFT_4Qxd-6sgks5rJEwVgaJpZM4LO1hf> .

[hplato]

Perfect, thanks for checking that out. I was thinking something like: $rrd_file = $args{rrd_file}[0] if ( defined $args{rrd_file}[0] ); This would allow different sources to be graphed with a URL like this: http://mh/ia7/#path=/rrd?now-6hour?indoor?rrd_file=doors.rrd Of course, that’s just theory, I haven’t really tested this out yet as I just have one RRD source...

…

On Dec 17, 2016, at 5:40 PM, Wayne Gatlin ***@***.***> wrote: weather_data.rrd is the default on a new install with no config settings, just tested with my dev system and weather_rrd_update.pl. I left the json config setting that was already there as the last option so it will override the mh.private.ini if its configured, is that what you mean? my $rrd_file = "weather_data.rrd"; $rrd_file = $config_parms{weather_data_rrd} if ( defined $config_parms{weather_data_rrd} ); if ( $rrd_file =~ m/.*\/(.*\.rrd)/ ) { $rrd_file = $1; } $rrd_file = $json_data{'rrd_config'}->{'prefs'}->{'default_rrd'} if ( defined $json_data{'rrd_config'}->{'prefs'}->{'default_rrd'} ); _Wayne On Sat, Dec 17, 2016 at 2:54 PM, hplato ***@***.***> wrote: > Since were changing the default weather RRD name, we should to check what > name gets created on a fresh install. > > I also thought it might be nice to have a JSON option to pass another rrd > as an option. This could be useful for folks that have more than one RRD on > their system > > - > > my $rrd_file = "weather.rrd"; > > > > - > > my $rrd_file = "weather_data.rrd"; > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#649 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AFZ3ea466bsklHq06IQmJFT_4Qxd-6sgks5rJEwVgaJpZM4LO1hf> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#649 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AExbSFUR9C2u6GaMlPVIbknAL274erOCks5rJIDvgaJpZM4LO1hf>.