Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scaffolding and version nums when 0.4 is finally recommended #503

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Update scaffolding and version nums when 0.4 is finally recommended #503

merged 9 commits into from
Dec 20, 2024

Conversation

pdaoust
Copy link
Collaborator

@pdaoust pdaoust commented Dec 6, 2024 •
edited
Loading

Should be good to go; just don't merge until 0.4 is out and recommended.

@pdaoust pdaoust requested a review from c12i December 6, 2024 21:51
@pdaoust pdaoust marked this pull request as ready for review December 9, 2024 23:40
matthme
matthme approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@matthme matthme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the small comment that I added.

@pdaoust pdaoust mentioned this pull request Dec 13, 2024
Open
16 tasks
@pdaoust pdaoust changed the title Update for scaffolding 0.4000 Update scaffolding and version nums when 0.4 is finally recommended Dec 20, 2024
matthme
matthme approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@matthme matthme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

ThetaSinner
ThetaSinner approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing that needs to happen in Holonix but the changes here look nice

src/pages/get-started/install-advanced.md Outdated Show resolved Hide resolved
@pdaoust pdaoust merged commit a6b6af1 into main Dec 20, 2024
6 checks passed
@pdaoust pdaoust deleted the 2024-12-06-updates-0.4 branch December 20, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c12i c12i c12i approved these changes

@matthme matthme matthme approved these changes

@ThetaSinner ThetaSinner ThetaSinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Holochain
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdaoust @ThetaSinner @matthme @c12i