Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(serde): pin to v1.0.166 #19

Merged
merged 4 commits into from
Sep 29, 2023
Merged

build(serde): pin to v1.0.166 #19

merged 4 commits into from
Sep 29, 2023

Conversation

jost-s
Copy link
Contributor

@jost-s jost-s commented Sep 29, 2023

No description provided.

@jost-s jost-s merged commit 956ae6d into main Sep 29, 2023
2 checks passed
@jost-s jost-s deleted the build/pin-serialization-crate branch September 29, 2023 02:21
@ThetaSinner
Copy link
Member

@jost-s I don't think this will pin to 1.0.166 in projects that use the client. Setting it like that is equivalent to setting a minimum version and letting the consumer choose an equal or higher version. The least intrusive way I could think of pinning in Holochain was using serde = { version = ">= 1.0, <= 1.0.166" }

https://github.com/holochain/holochain/blob/develop-0.2/crates/holochain/Cargo.toml#L60C1-L60C41

@jost-s
Copy link
Contributor Author

jost-s commented Oct 2, 2023

@ThetaSinner Sorry, that was bollix. I omitted the = sign. Does serde have to be between 1.0 and 1.0.166?

@ThetaSinner
Copy link
Member

It definitely has to be <= 1.0.166 but I think it leaves it more open for projects to be able to use any version of serde from 1.0 onwards

@ThetaSinner
Copy link
Member

I'm not sure if <= 1.0.166 implies >= 1.0 actually, maybe it does

@jost-s
Copy link
Contributor Author

jost-s commented Oct 2, 2023

Hard to know, yes. I'll copy the range you specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants