Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update rmp serde to v1 #48

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Conversation

jost-s
Copy link
Contributor

@jost-s jost-s commented Apr 10, 2024

rmp-serde is pinned to v0.15.5 and in conjunction with serde produces an unusual serialization for enums, e. g.

An enum in Rust

#[serde(tag = "type", content = "content")]
pub enum Authority {
    Agent(AgentPubKey),
}

serializes to

{
    "type": {
        "agent": null
    },
    "content": "uhCAkRNQ78aF5GvtY3dL4sLR66Xq_VeancOXV79iosN-hZdQ27BwU"
}

instead of

{
    "type": "agent",
    "content": "uhCAkRNQ78aF5GvtY3dL4sLR66Xq_VeancOXV79iosN-hZdQ27BwU"
}

part of holochain/holochain#3598

@jost-s jost-s merged commit fbdab15 into develop Apr 17, 2024
2 checks passed
@jost-s jost-s deleted the build/update-rmp-serde-to-v1 branch April 17, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants