Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasmer] Remove serialized module cache #3536

Open
jost-s opened this issue Apr 3, 2024 · 3 comments · May be fixed by holochain/holochain-wasmer#136
Open

[Wasmer] Remove serialized module cache #3536

jost-s opened this issue Apr 3, 2024 · 3 comments · May be fixed by holochain/holochain-wasmer#136
Assignees

Comments

@jost-s
Copy link
Contributor

jost-s commented Apr 3, 2024

holochain_wasmer has three caches:

  • a file system cache where serialized modules are stored
  • an in-memory cache where serialized modules are stored
  • an in-memory cache where deserialized modules are stored

The in-memory cache of serialized modules is redundant. If the module is not in the deserialized cache, which is the fastest way to obtain an executable module, it can either be found on the file system or needs to be compiled from wasm. There's no need to store it in serialized form in-memory.

@jost-s jost-s added this to Holochain Mar 12, 2024
@jost-s jost-s converted this from a draft issue Apr 3, 2024
@jost-s jost-s self-assigned this Apr 3, 2024
Copy link
Contributor

github-actions bot commented May 4, 2024

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 4, 2024
@abe-njama abe-njama removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 10, 2024
Copy link
Contributor

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jun 10, 2024
@abe-njama abe-njama removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jun 11, 2024
Copy link
Contributor

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jul 12, 2024
@abe-njama abe-njama added permanent Exempt this item from being marked stale and closed. and removed stale This issue may be outdated, but we can revive it if it ever becomes relevant again labels Jul 17, 2024
@jost-s jost-s assigned jost-s and unassigned jost-s Oct 22, 2024
@jost-s jost-s removed the permanent Exempt this item from being marked stale and closed. label Oct 29, 2024
@jost-s jost-s removed their assignment Oct 29, 2024
@jost-s jost-s moved this from Backlog to Ready for refinement in Holochain Oct 29, 2024
@jost-s jost-s self-assigned this Dec 11, 2024
@mattyg mattyg assigned mattyg and unassigned jost-s Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for refinement
Development

Successfully merging a pull request may close this issue.

3 participants