feat: remove in-memory SerializedModuleCache #136
Conversation
…rialized modules to filesystem into ModuleCache
| @@ -118,4 +168,56 @@ mod tests { | |||
| assert_eq!(*deserialized_cached_module, *module); | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn cache_get_from_fs() { | |||
There was a problem hiding this comment.
test that:
- builds module, serializes, writes to filesystem at expected path
- gets module from ModuleCache
- asserts that module now exists in deserialized in-memory path
| } | ||
|
|
||
| #[test] | ||
| fn cache_save_to_memory_only() { |
There was a problem hiding this comment.
Cache a module to in-memory deserialized module cache only
|
|
||
| #[test] | ||
| fn cache_test() { | ||
| fn cache_save_to_memory_and_fs() { |
There was a problem hiding this comment.
Cache a module to both filesystem and in-memory deserialized module caches
| @@ -266,109 +231,99 @@ impl SerializedModuleCache { | |||
| // instantiated with fresh stores free from state. Instance | |||
| // creation is highly performant which makes caching of instances | |||
| // and stores unnecessary. | |||
| let module = unsafe { | |||
| // | |||
| // See https://github.com/wasmerio/wasmer/issues/4377 | |||
There was a problem hiding this comment.
@jost-s can you confirm that this is the relevant issue?
| }; | ||
| self.put_item(key, Arc::new(serialized_module.clone())); | ||
| // Save serialized module to filesystem cache | ||
| self.add_to_filesystem_cache(key, serialized_module)?; |
There was a problem hiding this comment.
Note that we first save to filesystem, then add to in-memory cache. Thus if the process is interrupted after saving to the filesystem, it will still be added to the in-memory cache next time it is fetched.
But this made me realize -- if the process is interrupted while saving to the filesystem and the file is corrupted then it will error every time we try to deserialize it. I made an issue to address this: #137
Resolves holochain/holochain#3536
The diff is a hard to read but I think the code is more legible. Let me know if you think of more tests that would be good to add.