Test/add benchmark calls to tests #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyg
commented
Dec 13, 2024
| @@ -535,4 +535,147 @@ pub mod tests { | |||
|
|
|||
| assert_eq!(result, Vec::<u8>::from([1])); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
The tests below are copying the calls used in test/benches/bench.rs that were erroring.
ThetaSinner
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on CI, tests are passing but some benchmarks are failing inconsistently.
This adds test for all the wasm calls that are used in the benchmarks, to clarify that the errors only arise when the calls are run in benchmarks (i.e. when the wasm is instantiated and called 1000 - 1000000 times).
Edit: clearly the benchmark failures are inconsistent since CI is now passing here.
This PR is merging into chore/cleanup-make-private for a more legible diff.