Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump version to 0.0.97 #132

Merged
merged 3 commits into from
Dec 19, 2024
Merged

build: bump version to 0.0.97 #132

merged 3 commits into from
Dec 19, 2024

Conversation

mattyg
Copy link
Member

@mattyg mattyg commented Dec 18, 2024

No description provided.

- **BREAKING CHANGE** The `wasmer_sys` feature has been renamed to `wasmer_sys_dev`

### Added
- A new feature flag, `wasmer_sys_prod` which enables the Wasmer LLVM compiler. The default, with the `wasmer_sys_dev` feature
is the Cranelift compiler. The Cranelift compiler is fast, and recommended for development, but the LLVM compiler is supposed
to be faster and more optimized for production. In testing so far, the compile step is slower with LLVM but the runtime is
faster. More testing is needed yet to confirm the difference.
- A new public function `build_module`, which builds a wasmer Module directly, bypassing the `ModuleCache`. It is only implemented for the feature flag `wasmer_wamr`. On the feature flags `wasmer_sys_dev` and `wasmer_sys_prod` it will panic as unimplemented. This enforces the use of the `ModuleCache` when wasmer is used in a compiled mode, but allow bypassing the cache when wasmer is used in interpreter mode as caching is not relevant.

## [0.0.95] - 2024-08-28
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added changelog that were missing from the prior 2 versions

@mattyg mattyg marked this pull request as ready for review December 18, 2024 20:30
@mattyg mattyg requested a review from a team December 18, 2024 20:31
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thank you!

- **BREAKING CHANGE** The `wasmer_sys` feature has been renamed to `wasmer_sys_dev`

### Added
- A new feature flag, `wasmer_sys_prod` which enables the Wasmer LLVM compiler. The default, with the `wasmer_sys_dev` feature
is the Cranelift compiler. The Cranelift compiler is fast, and recommended for development, but the LLVM compiler is supposed
to be faster and more optimized for production. In testing so far, the compile step is slower with LLVM but the runtime is
faster. More testing is needed yet to confirm the difference.
- A new public function `build_module`, which builds a wasmer Module directly, bypassing the `ModuleCache`. It is only implemented for the feature flag `wasmer_wamr`. On the feature flags `wasmer_sys_dev` and `wasmer_sys_prod` it will panic as unimplemented. This enforces the use of the `ModuleCache` when wasmer is used in a compiled mode, and allows bypassing the cache when wasmer is used in interpreter mode as caching is not relevant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching is not relevant because modules are always built JIT? No caching possible?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is just the changelog ;-)

Copy link
Member Author

@mattyg mattyg Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant because in wasmer_wamr, the wasms are never compiled, they are interpreted. So constructing a wasmer Module is not an expensive process that produces a result we can cache to avoid duplicating that expense.

(in wamr mode, calling serialize() on a Module just gives you back the original wasm bytes)

@mattyg mattyg merged commit cd075dd into main Dec 19, 2024
13 checks passed
@mattyg mattyg deleted the release/0.0.97 branch December 19, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants