Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-enable ci on windows with wasmer_wamr feature #134

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

mattyg
Copy link
Member

@mattyg mattyg commented Dec 20, 2024

Resolves #117

Wasmer 5.x fixed the setup for building the wamr feature on windows. This just adds the necessary build dep and re-adds it to CI.

I'd prefer to keep this in now since it works fine, even if we don't support wasmer_wamr on windows or choose to drop it from CI when an issue arises.

@mattyg mattyg marked this pull request as ready for review December 20, 2024 21:34
@mattyg mattyg requested a review from a team December 20, 2024 22:15
@mattyg mattyg merged commit 8471690 into main Dec 20, 2024
14 checks passed
@mattyg mattyg deleted the fix/windows-ci branch December 20, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building on windows with wasmer_wamr feature
2 participants