feat: when deserialization of module from filesystem cache fails, remove from cache #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyg
commented
Dec 24, 2024
| /// Wasmer failed to serialize a Module to bytes. | ||
| ModuleSerialize(String), | ||
| /// Wasmer failed to deserialize a Module from bytes. | ||
| ModuleDeserialize(String), |
There was a problem hiding this comment.
Additional error types for clarity
mattyg
commented
Dec 24, 2024
| let module = match module_result { | ||
| Ok(d) => Ok(Arc::new(d)), | ||
| Err(e) => { | ||
| let _ = self.remove_from_filesystem_cache(key); |
There was a problem hiding this comment.
Remove from cache, but ignore any errors deleting the file (i.e. if it doesn't exist or user doesn't have permissions). Not sure if the error should be passed up.
mattyg
commented
Dec 24, 2024
|
|
||
| // Module cannot be retrieved from fs cache | ||
| let res = module_cache.get(key, &wasm); | ||
| assert!(res.is_err()); |
There was a problem hiding this comment.
Getting a corrupt file from the filesystem cache errors.
mattyg
commented
Dec 24, 2024
|
|
||
| // 2nd time, module can be retrieved from cache | ||
| let res = module_cache.get(key, &wasm).unwrap(); | ||
| assert_eq!(*res.serialize().unwrap(), *serialized_module); |
There was a problem hiding this comment.
After getting a corrupt file from the filesystem cache, it is removed from the filesystem, so the next get succeeds.
I'm not sure if a better approach would be to (1) remove it from the filesystem then (2) retry the get once, so the caller does not need to call get twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #137
Merging into
feat/rm-serialized-module-cachefor a clean diff.I'm not sure if this is the right approach, so let me know if you think differently.