Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename default flake template #14

Merged
merged 2 commits into from
Jun 13, 2024
Merged

chore: rename default flake template #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef07bba
chore: rename default flake template
jost-s Jun 6, 2024
d2ddf8d
fix(ci): update template name in workflow
jost-s Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- [ hc-scaffold ]
include:
- os: ubuntu-latest
template: holonix-default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is special, will it build with an empty string here? Then people can get the default template without specifying a template

template: default
fail-fast: false

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@
# Add content which is not platform specific after using flake-parts to generate platform specific content.
templates = {
# A template that can be used to create a flake that depends on this flake, with recommended defaults.
holonix-default = {
default = {
path = ./templates/default;
description = "Holonix default template";
};
Expand Down