-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial maintenance guide #145
Conversation
I'd actually quite like a document like this for Holochain. I think we have pieces of it but I'm not sure we've actually written down our PR/back-port process publicly. There are some HackMD docs and an agreement among the team but it'd be good to put it out there |
551ce37
to
0a0ad3e
Compare
0a0ad3e
to
065832b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i want to read over this again but spotted something that i'd like to report right away
guides/maintenance.md
Outdated
git checkout develop-0.1 | ||
git pull --tags | ||
git tag holochain-0.1 | ||
git push --tags origin holochain-0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this requires --force
to overwrite the tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot thank you. I suspect this guide will need some pipe cleaning and updates as we try to use it but would prefer to catch as much of this kind of thing as possible up front :)
065832b
to
7f9677b
Compare
1faf5c6
to
491ea6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks to be consistent including explaining expected exceptional cases to the default too, thanks! 👍 i left some small remarks as suggestions
491ea6a
to
8900eb7
Compare
Thanks for the review, I've taken the suggestions and will go ahead with getting this in :) |
Co-authored-by: Stefan Junker <[email protected]>
Co-authored-by: Stefan Junker <[email protected]>
4120021
to
3124922
Compare
I think this covers most things for a first pass. One notable thing missing is what 'bump the scaffolding version' means. This is an open discussion so I'll leave it out of the guide for the moment.