Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial maintenance guide #145

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Add initial maintenance guide #145

merged 5 commits into from
Nov 22, 2023

Conversation

ThetaSinner
Copy link
Member

@ThetaSinner ThetaSinner commented Nov 6, 2023

I think this covers most things for a first pass. One notable thing missing is what 'bump the scaffolding version' means. This is an open discussion so I'll leave it out of the guide for the moment.

@ThetaSinner ThetaSinner changed the title Add maintenance guide Add initial maintenance guide Nov 6, 2023
@ThetaSinner
Copy link
Member Author

ThetaSinner commented Nov 6, 2023

I'd actually quite like a document like this for Holochain. I think we have pieces of it but I'm not sure we've actually written down our PR/back-port process publicly. There are some HackMD docs and an agreement among the team but it'd be good to put it out there

@ThetaSinner ThetaSinner force-pushed the add-maintenance-guide branch from 551ce37 to 0a0ad3e Compare November 6, 2023 13:43
@ThetaSinner ThetaSinner marked this pull request as draft November 6, 2023 13:56
@ThetaSinner ThetaSinner force-pushed the add-maintenance-guide branch from 0a0ad3e to 065832b Compare November 6, 2023 14:38
Copy link
Member

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to read over this again but spotted something that i'd like to report right away

git checkout develop-0.1
git pull --tags
git tag holochain-0.1
git push --tags origin holochain-0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this requires --force to overwrite the tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot thank you. I suspect this guide will need some pipe cleaning and updates as we try to use it but would prefer to catch as much of this kind of thing as possible up front :)

@ThetaSinner ThetaSinner force-pushed the add-maintenance-guide branch from 065832b to 7f9677b Compare November 8, 2023 12:37
@ThetaSinner ThetaSinner marked this pull request as ready for review November 8, 2023 14:43
@ThetaSinner ThetaSinner force-pushed the add-maintenance-guide branch from 1faf5c6 to 491ea6a Compare November 8, 2023 16:54
Copy link
Member

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to be consistent including explaining expected exceptional cases to the default too, thanks! 👍 i left some small remarks as suggestions

guides/maintenance.md Outdated Show resolved Hide resolved
guides/maintenance.md Outdated Show resolved Hide resolved
@ThetaSinner ThetaSinner force-pushed the add-maintenance-guide branch from 491ea6a to 8900eb7 Compare November 22, 2023 12:30
@ThetaSinner
Copy link
Member Author

Thanks for the review, I've taken the suggestions and will go ahead with getting this in :)

@ThetaSinner ThetaSinner force-pushed the add-maintenance-guide branch from 4120021 to 3124922 Compare November 22, 2023 12:46
@ThetaSinner ThetaSinner merged commit 3784315 into develop Nov 22, 2023
1 check passed
@ThetaSinner ThetaSinner deleted the add-maintenance-guide branch November 22, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants