Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get links #155

Merged
merged 17 commits into from
Nov 25, 2023
Merged

Refactor get links #155

merged 17 commits into from
Nov 25, 2023

Conversation

guillemcordoba
Copy link
Collaborator

Closes #151

Depends on #154

@mattyg
Copy link
Member

mattyg commented Nov 17, 2023

Heads up @guillemcordoba holochain-client-js doesn't actually define a Link type

Edit: nevermind just pulled latest changes!

@guillemcordoba
Copy link
Collaborator Author

Hehe we are riding the PR wave!

@guillemcordoba
Copy link
Collaborator Author

Waiting on holochain/holochain-client-js#217 to be fixed

@ThetaSinner
Copy link
Member

Is this ready to review?

@ThetaSinner
Copy link
Member

Oh I see I was just invited to review so yes, will take a look

Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing and it's tricky to follow all the templating details but I trust the tests to take care of that. The change looks good to me!

src/scaffold/link_type/coordinator.rs Outdated Show resolved Hide resolved
@ThetaSinner ThetaSinner added the ShouldBackport/0.2 This change should be backported to develop-0.2 label Nov 24, 2023
@guillemcordoba guillemcordoba merged commit fd1bd71 into develop Nov 25, 2023
1 check passed
@guillemcordoba guillemcordoba deleted the refactor-get-links branch November 25, 2023 16:42
ThetaSinner pushed a commit that referenced this pull request Nov 28, 2023
@ThetaSinner ThetaSinner removed the ShouldBackport/0.2 This change should be backported to develop-0.2 label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link-type design improvements
3 participants