-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor get links #155
Refactor get links #155
Conversation
Edit: nevermind just pulled latest changes! |
Hehe we are riding the PR wave! |
Waiting on holochain/holochain-client-js#217 to be fixed |
Is this ready to review? |
Oh I see I was just invited to review so yes, will take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing and it's tricky to follow all the templating details but I trust the tests to take care of that. The change looks good to me!
Closes #151
Depends on #154