Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Nix failure due to Git conflict #156

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ThetaSinner
Copy link
Member

@ThetaSinner ThetaSinner commented Nov 16, 2023

There's a code comment explaining this one but I'll post the before and after here to make it clearer. When running Scaffolding inside a Git repository I was getting:

✔ App name (no whitespaces): · asdf
✔ Choose UI framework: · Vue
✔ Do you want to set up the holonix development environment for this project? · Yes (recommended)
Setting up nix development environment...
error: getting status of '/nix/store/2jbblm8bwyv0kq1k9r6dxy7q735d8v2c-source/asdf': No such file or directory
Error: Error setting up the nix environment

After this change, it tells you what the problem is:

✔ App name (no whitespaces): · asdf
✔ Choose UI framework: · Vue
✔ Do you want to set up the holonix development environment for this project? · Yes (recommended)
Error: Error setting up the nix environment - detected that Scaffolding is running inside an existing Git repository, please choose a different location to scaffold

This is very much a Nix flakes gotcha but I think it's helpful to tell people what's happening if possible.

@ThetaSinner ThetaSinner added ShouldBackport/0.1 This change should be backported to develop-0.1 ShouldBackport/0.2 This change should be backported to develop-0.2 labels Nov 16, 2023
@ThetaSinner ThetaSinner disabled auto-merge November 16, 2023 12:51
@ThetaSinner ThetaSinner merged commit 5ebdb3b into develop Nov 16, 2023
1 check passed
@ThetaSinner ThetaSinner deleted the detect-nix-failure-before-it-happens branch November 16, 2023 13:40
ThetaSinner added a commit that referenced this pull request Nov 28, 2023
…appens

Detect Nix failure due to Git conflict
ThetaSinner added a commit that referenced this pull request Nov 28, 2023
…appens

Detect Nix failure due to Git conflict
ThetaSinner added a commit that referenced this pull request Nov 28, 2023
…appens

Detect Nix failure due to Git conflict
@ThetaSinner ThetaSinner removed ShouldBackport/0.2 This change should be backported to develop-0.2 ShouldBackport/0.1 This change should be backported to develop-0.1 labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants