Fix Vue bool and timestamp #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
added
ShouldBackport/0.1
ThetaSinner
commented
Nov 21, 2023
| @@ -1 +1 @@ | |||
| {{{{raw}}}} {{ {{{{/raw}}}} new Date({{variable_to_read}} / 1000).toLocaleString() {{{{raw}}}} }} {{{{/raw}}}} | |||
| {{{{raw}}}} {{ {{{{/raw}}}} {{variable_to_read}} ? new Date({{variable_to_read}} / 1000).toLocaleString() : 'Missing timestamp' {{{{raw}}}} }} {{{{/raw}}}} | |||
There was a problem hiding this comment.
Produces
<span style="white-space: pre-line">{{ jklh?.when ? new Date(jklh?.when / 1000).toLocaleString() : 'Missing timestamp' }} </span>
Instead of
<span style="white-space: pre-line">{{ new Date(jklh?.when / 1000).toLocaleString() }} </span>
Which is not valid TypeScript as you can't divide undefined by a number
ThetaSinner
force-pushed
the
fix-vue-bool-and-timestamp
branch
from
0e7484f to
55c135a
Compare
ThetaSinner
force-pushed
the
fix-vue-bool-and-timestamp
branch
from
55c135a to
87db651
Compare
ThetaSinner
added a commit
that referenced
this pull request
Nov 28, 2023
Fix Vue bool and timestamp
ThetaSinner
added a commit
that referenced
this pull request
Nov 28, 2023
Fix Vue bool and timestamp
ThetaSinner
added a commit
that referenced
this pull request
Nov 28, 2023
Fix Vue bool and timestamp
ThetaSinner
removed
ShouldBackport/0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into these while testing another change. It looks like these types aren't covered by the automated tests, something that would be good to cover because these typescript errors prevent the app running