feat: Improve hc-scaffold entry-type developer experience
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selection; refactor FieldType parsing
c12i
changed the title
hc-scaffold entry-type developer experience
c12i
commented
Oct 9, 2024
…m-field-type-prompts
c12i
removed
the
ShouldBackport/0.4
c12i
added a commit
to c12i/scaffolding
that referenced
this pull request
Oct 17, 2024
…n#383) * refactor enum type selection; add option to restart field type selection; refactor FieldType parsing * Improve EntryTypeReference parsing * Improve parse_enum parsing logic * Update field_type parsing logic
c12i
added a commit
that referenced
this pull request
Oct 21, 2024
* Bump crate version * feat: Create links from/to `ExternalHash` (#380) * add ExternalHash field types and option to target this type when scaffolding a link-type * ensure external hash is imported in type declarations * feat: create links from/to AnyLinkableHash * Add AnyLinkablehHash field type templates and add to reserved words * fix failed to resolve errors * improve checking for reserved keywords * fix invalid link-type delete method in test template * simplify reserved_words hashsets * update cli * Extend reserved keywords to check for javascript keywords * Update AnyLinkableHash sample value * Extend reserved words check tests * fix AnyLinkableHash link-type tests * Fix AnyLinkableHash link-type tests and remove redundant AND/OR hbs helpers * update inner_choose_referenceable * /AnyLinkableHash/ExternalHash * Update invalid serserved word error message * Refactor entry/link type utils * Add some context to the [None] option when scaffolding a link-type * /AnyLinkableHash/ExternalHash in link-type template * Fix option placement * Prevent UI from getting generated where the base type of a link is an ExternalHash * ExternalHash links can be bidirectional * Only skip ui if to_referenceable is some and the field_type is of ExternalHash * Remove unnecessary into call in delete link function * Fix rustfmt ci failure * Fix missing conversion * Fix react link-type template * feat: Improve `hc-scaffold entry-type` developer experience (#383) * refactor enum type selection; add option to restart field type selection; refactor FieldType parsing * Improve EntryTypeReference parsing * Improve parse_enum parsing logic * Update field_type parsing logic * fix: Optimize nix flake (#384) * optimize nix flake * Supress clippy warnings * Nix flake update
c12i
added a commit
that referenced
this pull request
Oct 31, 2024
* refactor enum type selection; add option to restart field type selection; refactor FieldType parsing * Improve EntryTypeReference parsing * Improve parse_enum parsing logic * Update field_type parsing logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
choose_fields, incase there was an error or mistake when creating a field for their entry type. This is a first step towards the replay functionality, further improvements to this can be made with (a) separate PR(s) i.e to modify/add/delete specific fields rather than starting over (first of feat: Add ability to go back and change field type after the fields are initially selected Components#76 and feat: Add ability to go back when adding entries #53)input_with_custom_validationfunction to continue to re-prompt the user for input incase the validation fails rather than exiting the operation altogether (first step towards addressing feat: Where possible, try to re-prompt the the user on invalid inputs rather than exiting the program #387)FieldDefinitionandEntryTypeReferenceparsing logic to enhance resilience and better error handlingselection; refactor FieldType parsing