Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimize nix flake #384

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Oct 11, 2024

This PR optimizes the local development nix flake to only include nixpkgs it requires in its devshell

@c12i c12i requested a review from matthme October 11, 2024 09:57
@c12i c12i added ShouldBackport/0.3 This change should be backported to develop-0.3 ShouldBackport/0.4 This change should be backported to develop-0.1 labels Oct 11, 2024
@c12i c12i force-pushed the update-nix-flake-inputs branch from ac93a7b to ee9f9df Compare October 11, 2024 10:29
@c12i c12i merged commit 145f1f8 into holochain:develop Oct 11, 2024
8 checks passed
@c12i c12i removed the ShouldBackport/0.3 This change should be backported to develop-0.3 label Oct 17, 2024
c12i added a commit to c12i/scaffolding that referenced this pull request Oct 17, 2024
* optimize nix flake

* Supress clippy warnings
c12i added a commit to c12i/scaffolding that referenced this pull request Oct 17, 2024
* optimize nix flake

* Supress clippy warnings
c12i added a commit that referenced this pull request Oct 21, 2024
* Bump crate version

* feat: Create links from/to `ExternalHash` (#380)

* add ExternalHash field types and option to target this type when scaffolding a link-type

* ensure external hash is imported in type declarations

* feat: create links from/to AnyLinkableHash

* Add AnyLinkablehHash field type templates and add to reserved words

* fix failed to resolve errors

* improve checking for reserved keywords

* fix invalid link-type delete method in test template

* simplify reserved_words hashsets

* update cli

* Extend reserved keywords to check for javascript keywords

* Update AnyLinkableHash sample value

* Extend reserved words check tests

* fix AnyLinkableHash link-type tests

* Fix AnyLinkableHash link-type tests and remove redundant AND/OR hbs
helpers

* update inner_choose_referenceable

* /AnyLinkableHash/ExternalHash

* Update invalid serserved word error message

* Refactor entry/link type utils

* Add some context to the [None] option when scaffolding a link-type

* /AnyLinkableHash/ExternalHash in link-type template

* Fix option placement

* Prevent UI from getting generated where the base type of a link is an
ExternalHash

* ExternalHash links can be bidirectional

* Only skip ui if to_referenceable is some and the field_type is of
ExternalHash

* Remove unnecessary into call in delete link function

* Fix rustfmt ci failure

* Fix missing conversion

* Fix react link-type template

* feat: Improve `hc-scaffold entry-type` developer experience (#383)

* refactor enum type selection; add option to restart field type
selection; refactor FieldType parsing

* Improve EntryTypeReference parsing

* Improve parse_enum parsing logic

* Update field_type parsing logic

* fix: Optimize nix flake (#384)

* optimize nix flake

* Supress clippy warnings

* Nix flake update
c12i added a commit that referenced this pull request Oct 22, 2024
* feat: add optional cli flag to skip test code generation (#381)

* Bump crate version

* fix: preserve line comments on creating/ modifying rust code (#382)

* Refactor un_parse_pretty function

* Move important scaffold functions to the top of the module for easy accesss

* fix improper use of bool.then_some

* ensure line comments are preserved

* derive a convert rust line comments to doc comments util function and apply to map_rust_files function

* ensure initially generated comments are correctly formatted

* remove unnecessary inline attribute on unparse_pretty

* Replace once_cell::Lazy with standard lib LazyLock

* fix: Optimize nix flake (#384)

* optimize nix flake

* Supress clippy warnings

* nix flake update

* Replace LazyCell with once_cell::Lazy

* Cargo update dprint-plugin-typescript
@c12i c12i removed the ShouldBackport/0.4 This change should be backported to develop-0.1 label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants