feat: Add ability to go back and modify entry type fields #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12i
added
ShouldBackport/0.3
cdunster
reviewed
Nov 21, 2024
|
I always get an error that a flake.nix is missing: $ hc-scaffold example forum
✔ Choose UI framework: (Use arrow-keys. Return to submit) · lit
✔ Choose a package manager: (Use arrow-keys. Return to submit) · npm
Setting up nix development environment...
error: path '/nix/store/90xdfxqppbfn7zk92z0hnjf9j5mfsham-source/forum/flake.nix' does not exist
Error setting up the nix environmentIt happens regardless of template and with |
|
@jost-s this is strange, I'm unable to reproduce, were you running this inside or outside a nix shell? |
|
I was running it outside of a nix shell. Now running inside of it, I get the same error: nix: scaffolding (feat/entry-type-go-back) $ hc-scaffold example hello-world
✔ Choose a package manager: (Use arrow-keys. Return to submit) · npm
Setting up nix development environment...
error: path '/nix/store/90xdfxqppbfn7zk92z0hnjf9j5mfsham-source/hello-world/flake.nix' does not exist
Error setting up the nix environment I'll start from scratch again. |
|
I end up at the same error. Here's what I do: |
|
@jost are you running this inside the scaffolding repo? I think that's the problem. It works fine outside in a separate folder. |
|
But I can reproduce it if I run it inside the scaffolding repo. |
matthme
approved these changes
Nov 26, 2024
|
Right, that's the difference then. I was able to test like this before, I must have done it in a separate folder. Thanks @matthme |
c12i
removed
the
ShouldBackport/0.3
c12i
added a commit
that referenced
this pull request
Dec 10, 2024
* Add go back functionality for hc scaffold entry-type * address PR comments * Ensure the fields vec is not empty on change * Improve text spacing * Simplify prompt
c12i
removed
the
ShouldBackport/0.4
c12i
added a commit
that referenced
this pull request
Dec 12, 2024
* fix: Skip writing scaffold config for nixified custom templates (#415) * Add skip_config_check global flag to scaffolding * Prefer not writing the scaffold config for nixified custom templates * Fix rustfmt warning * feat: further improve ci runtime (#414) * Remove dependency to holochain * Add rust-cache * Add cachix nix config * Add ci job concurrency options * Update cachix configurations * Run rust checks/tests outside nix * add missing components * Cache rust builds * Bump holochain deps * Update rustdocs * Build cargo deps separately * refactor flake * Update maintenance docs * Add extraPullNames input to cachix actions * Add nix_build step * Extend extra-substituters and public-keys in nixConfig * Fix ci workflow * Bump client-js version * fix: Fix misplaced doc comments (#411) * Fix misplaced doc comments * Slightly refactor link_type integrity codegen * feat: Enhance custom template generation (#404) * feat: Add a new template subcommand to create new custom template bases from existing templates * Remove call to wrapCustoTemplate in scaffolding nix flake * Update custom template docs * chore: update ui dependencies (#407) * Bump holochain playground * Update ui core dependencies * Update lit dependencies * Fix cli output lines * Fix broken css import in lit template * Revert custom-template changes * Fix vue templates * Increase testTimeout * Remove eslint from lit template * Fix lit CI failure * Add missing shared styles * feat: Reprompt user on invalid input (#402) * Fix imports * Merge pull request #428 from holochain/fix/svelte-client-race-condition-0.4 chore: backport svelte race condition to 0.4 and release 0.4000.0-rc.1 * feat: Add ability to go back and modify entry type fields (#418) * Add go back functionality for hc scaffold entry-type * address PR comments * Ensure the fields vec is not empty on change * Improve text spacing * Simplify prompt * Pin typescript version for vue-tsc compatibility --------- Co-authored-by: matthme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #53