Fix race condition in Svelte template #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthme
added
ShouldBackport/0.3
|
Nice; I like the addition of a typedef for the client context. Kinda annoying that you had to edit all the files; thanks for doing that work! (I looked over it for correctness but didn't scour to see if you'd missed any templates or example files; assuming you've done that ;) ) |
|
I tried to catch all yes :) With search I think it's quite easy to see all occurrences so I'm quite confident. |
pdaoust
approved these changes
Dec 5, 2024
matthme
removed
ShouldBackport/0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition where Svelte components would try to access the client context when it's not yet defined.