Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add helper util conductorCellsDhtSync -- alternative to dhtSync #188

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

mattyg
Copy link
Member

@mattyg mattyg commented Oct 3, 2023

@jost-s I know we went back and forth on this api in #178. I now need a version of dhtSync() that takes in a conductor, rather than a player.

This adds duplicated functions conductorCellDhtSync and isConductorCellDhtEqual and makes the prior versions aliases to these.

They take in a IConductorCell which just wraps an IConductor and CellId.

It's not clear why, but the docs aren't building for me.

@mattyg mattyg changed the title feat: add helper util conductorCellsDhtSync -- alias for dhtSync feat: add helper util conductorCellsDhtSync -- alternative to dhtSync Oct 3, 2023
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, cool! LGTM

@jost-s jost-s merged commit ae18d92 into holochain:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants