Add roles settings #246
Add roles settings #246
Conversation
| @@ -1071,22 +1070,22 @@ export class TryCpConductor implements IConductor { | |||
| const agent_key = | |||
| appForAgent.agentPubKey ?? | |||
| (await this.adminWs().generateAgentPubKey()); | |||
| const membrane_proofs = appForAgent.membraneProofs ?? {}; | |||
| const roles_settings = appForAgent.rolesSettings; | |||
There was a problem hiding this comment.
Is is safe to assume that appForAgent.roleSettings will not be null or undefined and we do not need a fallback value anymore?
There was a problem hiding this comment.
undefined is a valid input to the InstallAppPayload so this should be fine either way.
| { progenitor: progenitorKey } | ||
| ); | ||
| t.equal(provisionedCell.dna_modifiers.origin_time, originTime); | ||
| t.deepEqual(provisionedCell.dna_modifiers.quantum_time, quantumTime); |
There was a problem hiding this comment.
not sure if its overkill but should we add an assertion that the membrane proof is commited to our chain?
There was a problem hiding this comment.
I think that's overkill, because we're not testing the correctness of Holochain here.
| { progenitor: progenitorKey } | ||
| ); | ||
| t.equal(provisionedCell.dna_modifiers.origin_time, originTime); | ||
| t.deepEqual(provisionedCell.dna_modifiers.quantum_time, quantumTime); |
There was a problem hiding this comment.
I think that's overkill, because we're not testing the correctness of Holochain here.
|
Thank you! Addressed your suggestions @jost-s and will merge if the tests pass. |
* add new roles-settings field * fix role name * added changelog * buump holochain_conductor_api * address suggestions
* Backport Add roles settings (#246) * add new roles-settings field * fix role name * added changelog * buump holochain_conductor_api * address suggestions * add missing import
No description provided.