Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild attractors #250

Merged
merged 14 commits into from
Oct 19, 2023
Merged

Rebuild attractors #250

merged 14 commits into from
Oct 19, 2023

Conversation

maximlt
Copy link
Contributor

@maximlt maximlt commented Jan 24, 2023

All the projects will be rebuilt and deployed to a new user on AE5. Attractors already has a deployment at https://attractors.pyviz.demo.anaconda.com/. It will have to be shut down so that the system here can deploy it automatically:

@maximlt
Copy link
Contributor Author

maximlt commented Jan 27, 2023

Fixed two bugs in attractors_panel which together caused to app to be permanently down:

  • the app allowed the user to overwrite attractors.yml from which the set of examples is loaded
  • one of these examples was invalid, and when a user would shuffle/sort the examples AND save then this invalid example would end up being first in the list of examples for that attractor type, the app gets initialized by the first example for each attractor and would then fail, on start.

The changes made were:

  • prevented users from overwriting the default file, now they save their changes to another file that cannot be named as the default file
  • removed the invalid attractor example

I made a couple of small changes, for instance shuffling/sorting was not modifying in place the list of examples and as such the scrubber options would not get updated.

@maximlt maximlt mentioned this pull request Jan 29, 2023
@github-actions
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt merged commit 601c099 into main Oct 19, 2023
9 checks passed
@maximlt maximlt deleted the rebuild_attractors branch October 19, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant