Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSM #293

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Update OSM #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9b6b8e
start to fix validation
maximlt Oct 19, 2023
e010514
relock
maximlt Oct 30, 2023
5621739
push evaluated notebooks
maximlt Oct 30, 2023
4d425c6
skip tests
maximlt Oct 30, 2023
8dcd08b
update titles
maximlt Oct 30, 2023
f024514
really skip the tests
maximlt Oct 30, 2023
a95310f
create parents dir
maximlt Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions dodo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,10 +469,10 @@ def should_skip_test(name):
"""
Determines whether testing a project should be skipped.
"""
skip_test = False
if skip_test:
print('skip_test: True')
return False
# skip_test = False
# if skip_test:
# print('skip_test: True')
# return False

# TODO: remove it if not needed
# Prepared for when skip_test is added
Expand Down Expand Up @@ -1019,7 +1019,7 @@ def validate_project_file(name):
required_config = ['created', 'maintainers', 'labels']
optional_config = [
'last_updated', 'deployments', 'skip_notebooks_evaluation',
'no_data_ingestion', 'title', 'gh_runner',
'no_data_ingestion', 'title', 'gh_runner', 'skip_test',
]
for key in user_config:
if key not in required_config + optional_config:
Expand Down Expand Up @@ -1462,6 +1462,8 @@ def remove_test_data(name, root='', test_data='test_data', cat_filename='catalog
yield {
'name': name,
'actions': [(copy_test_data, [name])],
# TODO: remove if all the projects can actually be tested
'uptodate': [(should_skip_test, [name])],
'clean': [(remove_test_data, [name])],
}

Expand Down Expand Up @@ -1490,6 +1492,7 @@ def prepare_project(name):
yield {
'name': name,
'actions': [(prepare_project, [name])],
# TODO: remove if all the projects can actually be tested
'uptodate': [(should_skip_test, [name])],
'clean': [f'rm -rf {name}/envs'],
}
Expand All @@ -1510,6 +1513,7 @@ def lint_notebooks(name):
yield {
'name': name,
'actions': [(lint_notebooks, [name])],
# TODO: remove if all the projects can actually be tested
'uptodate': [(should_skip_test, [name])],
}

Expand Down Expand Up @@ -1715,7 +1719,7 @@ def copy_notebooks(name):
for notebook in notebooks:
out_dir = pathlib.Path('doc', 'gallery', name)
if not out_dir.exists():
out_dir.mkdir()
out_dir.mkdir(parents=True)
dst = out_dir / notebook.name
print(f'Copying notebook {notebook} to {dst}')
shutil.copyfile(notebook, dst)
Expand Down
Loading