Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gull_tracking: modernized project example #357

Merged
merged 16 commits into from
Mar 6, 2024
Merged

gull_tracking: modernized project example #357

merged 16 commits into from
Mar 6, 2024

Conversation

Azaya89
Copy link
Collaborator

@Azaya89 Azaya89 commented Feb 2, 2024

  • Modernized example
  • Added explanations for the code
  • Discuss hosting the file on our S3 due to the lack of the content-length in the response from Zenodo preventing any progress bar to be displayed by anaconda-project?

@Azaya89 Azaya89 requested a review from maximlt February 2, 2024 09:39
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I left the lnglat_to_meters function as is since I don't know the equivalent function from hvplot.

The utility to convert the coordinates is the HoloViews hv.util.transform.lon_lat_to_easting_northing function. You've seen it in use already in the HoloViz tutorial (https://holoviz.org/tutorial/Composing_Plots.html). Can you please update the code to use it instead?

I've left some other comments, good start! :)

gull_tracking/gull_tracking.ipynb Show resolved Hide resolved
gull_tracking/gull_tracking.ipynb Outdated Show resolved Hide resolved
@maximlt maximlt changed the title modernized project example gull_tracking: modernized project example Feb 2, 2024
@maximlt maximlt added the NF SDG NumFocus Software Development Grant 2024 label Feb 2, 2024
@Azaya89 Azaya89 requested a review from maximlt February 2, 2024 12:39
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, thanks!

gull_tracking/gull_tracking.ipynb Show resolved Hide resolved
gull_tracking/gull_tracking.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 7, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@Azaya89 Azaya89 self-assigned this Feb 15, 2024
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I feel it would be good to describe more the dataset before displaying it. I'd suggest showing the output of df.head() and len(df). The output of df.describe() wouldn't be very interesting, I think, as we only read the lat/lon columns (the CSV has more columns). The text says there are 2.4 million points in the dataset but as someone looking at this example I'd rather see the output of a code cell show that :)

image

I was a bit stumped by the fact that the map wasn't centered on the dataset. Running the notebook, I found out that there are 4 points farther West and North.

image
image

(These data points are actually displayed on the map, but they're very small and have a dark color. We use dynspread=True to deal with this kind of case, maybe its settings like threshold and max_px need to be adjusted to better display these isolated points. @jbednar)

I think the example would look better if there was a plot focused on where most of the points are. For example, after removing these points (e.g. df = df[(df['location-long'] > -14) & (df['location-lat'] < 53.3)]), the map looks better I think:

image

@maximlt
Copy link
Contributor

maximlt commented Feb 26, 2024

I stored a copy of the file on our S3 and updated the anaconda-project.yml accordingly.

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@Azaya89 Azaya89 requested a review from maximlt February 26, 2024 22:41
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the latest changes, merging :)

@maximlt maximlt merged commit dcbcc0e into main Mar 6, 2024
9 checks passed
@Azaya89 Azaya89 deleted the update-eg branch March 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NF SDG NumFocus Software Development Grant 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants