Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the ship_traffic notebook to match AE5 deployment #359

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

jlstevens
Copy link
Contributor

Updates the project to match the AE5 version.

Fixes the legends and adds instant inspection although this approach is somewhat ugly.

image

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis droumis self-requested a review June 26, 2024 22:15
Copy link
Contributor

@droumis droumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following can be removed, no? I don't see where it is used

def convert(x):
    try:
        return int(x)
    except:
        return 0

@droumis
Copy link
Contributor

droumis commented Jun 26, 2024

Is there a workaround or alternative for getting the images from marinetraffic website? Looks like they are now blocking programmatic access now

@droumis
Copy link
Contributor

droumis commented Jun 26, 2024

I removed the unnecessary code.
I will file an issue about the restricted access to the image data.

will merge as-is now

@droumis droumis self-requested a review June 26, 2024 22:30
@droumis droumis merged commit ebf03d4 into main Jun 26, 2024
7 of 8 checks passed
Azaya89 pushed a commit that referenced this pull request Jul 4, 2024
* Updates the ship_traffic notebook to match AE5 deployment

* Remove unnecessary code

---------

Co-authored-by: Demetris Roumis <[email protected]>
@maximlt maximlt deleted the ship_traffic_updates branch October 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants