Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last update date #387

Closed
wants to merge 2 commits into from
Closed

Fix last update date #387

wants to merge 2 commits into from

Conversation

hoxbro
Copy link
Contributor

@hoxbro hoxbro commented May 23, 2024

Fixes #374

I haven't tested it out; I'm pretty sure this is why the last update date doesn't show up correctly. I think this is where fetch-depth should be set, but please correct me if it is not.

@hoxbro hoxbro requested a review from maximlt May 23, 2024 09:15
Copy link
Contributor

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@hoxbro hoxbro marked this pull request as draft May 23, 2024 09:25
@hoxbro hoxbro removed the request for review from maximlt May 23, 2024 09:26
Copy link
Contributor

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch I think. I wonder how you find the time to look into the issues of all the repositories we have!

@hoxbro
Copy link
Contributor Author

hoxbro commented May 23, 2024

Unfortunately, it didn't seem to work 🙃

I don't know when I will have time to dive deeper into why this is the case.

@maximlt
Copy link
Contributor

maximlt commented Oct 10, 2024

Unfortunately, it didn't seem to work 🙃

I don't know when I will have time to dive deeper into why this is the case.

Ended up with the same fix in #425, not sure why it didn't work here.

@maximlt maximlt closed this Oct 10, 2024
@hoxbro hoxbro deleted the fix_last_update branch October 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last updated date does not match GitHub last commit date
2 participants