Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting by last updated date or title #409

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Add sorting by last updated date or title #409

merged 3 commits into from
Aug 7, 2024

Conversation

droumis
Copy link
Contributor

@droumis droumis commented Aug 5, 2024

This won't look like it's working yet on the deployed site because of #374

But here it is working on my local build:

GMT20240805-230323_Clip_Demetris.Roumis.s.Clip.08_05_2024.mp4

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@droumis droumis marked this pull request as ready for review August 5, 2024 23:05
@droumis droumis changed the title WIP Add widget to sort by last updated date or title Add sorting by last updated date or title Aug 5, 2024
@droumis droumis requested a review from jlstevens August 5, 2024 23:06
@jlstevens
Copy link
Contributor

Thank you!

Having the option to sort will make the tile view even more useful. Sorting by name and last updated are the most important things but if we have the metadata for it, we can also imagine sorting by author name, creation date etc.

@droumis
Copy link
Contributor Author

droumis commented Aug 6, 2024

Thank you!

Having the option to sort will make the tile view even more useful. Sorting by name and last updated are the most important things but if we have the metadata for it, we can also imagine sorting by author name, creation date etc.

Sure, but in future PRs

@droumis
Copy link
Contributor Author

droumis commented Aug 6, 2024

@jlstevens, alright to merge?

@jlstevens
Copy link
Contributor

Thanks!

@droumis droumis merged commit 85a730a into main Aug 7, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Your changes were successfully integrated in the dev site, make sure to review
the pages of the projects you touched before merging this PR: https://holoviz-dev.github.io/examples/.
You can also download an archive of the site from the workflow summary page which comes in handy
when your dev site built was overriden by another PR (we have a single dev site!).

@maximlt maximlt deleted the sort_date branch October 8, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants