Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies dynamically from core #108

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Install dependencies dynamically from core #108

merged 6 commits into from
Apr 10, 2024

Conversation

edenhaus
Copy link
Contributor

No description provided.

hassfest/Dockerfile Outdated Show resolved Hide resolved
hassfest/Dockerfile Outdated Show resolved Hide resolved
COPY entrypoint.sh /entrypoint.sh
COPY requirements.txt .

RUN uv pip install -r requirements.txt
RUN \
uv pip install -r requirements.txt \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, as this file now only contains a single item, we can just install it directly here, and save 1 layer by not needing to copy the file.

Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ludeeus ludeeus merged commit d371da1 into master Apr 10, 2024
9 checks passed
@ludeeus ludeeus deleted the dynamic-deps branch April 10, 2024 07:34
@edenhaus edenhaus mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants