Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create, update and delete KNX entities from UI / WS-commands #104079
Create, update and delete KNX entities from UI / WS-commands #104079
Changes from all commits
a447040
cc11f56
afc9b43
56d12c5
549a7f9
f91dd07
2084062
13c28e2
5580d58
88611a5
1cf08e5
f50925d
e21bd0c
eb77652
83d54ac
bada30d
8e8b68b
e1ee4d2
fac7d61
efb54f9
ee30f59
13738b1
804ea00
6a9a76c
caaa0a1
43b5514
c81a1ba
a6a10f8
85afe05
9fa1615
4ef3979
5aa6434
c2901be
b938cc5
2a659e1
26c251d
70d0ef7
9da038e
92df5f5
1e17c1a
623c55a
89339fa
468ec6c
5f40e7f
9280e81
8ca664f
4d6b694
e7b44a7
48fe094
d0fc065
0f71ede
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel extra fancy, maybe you can do https://developers.home-assistant.io/blog/2024/05/01/improved-hass-data-typing (but in a separate PR of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do fancy type safety for sure!
Maybe I can even use
runtime_data
, but for now I'm trying to avoid merge conflict hell 😬 (I have some follow-ups ready locally 🙃)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure data loading in
KNXModule.start()
is robust and error-handled.Consider adding error handling around the data loading calls in
KNXModule.start()
to manage potential failures gracefully. This could improve the robustness of the module startup process.Check warning on line 70 in homeassistant/components/knx/storage/config_store.py
Codecov / codecov/patch
homeassistant/components/knx/storage/config_store.py#L70
Check warning on line 99 in homeassistant/components/knx/storage/config_store.py
Codecov / codecov/patch
homeassistant/components/knx/storage/config_store.py#L99
Check warning on line 131 in homeassistant/components/knx/storage/config_store.py
Codecov / codecov/patch
homeassistant/components/knx/storage/config_store.py#L130-L131