-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity picker: Change "Create a new entity" to "Creates …" for clarity #22921
base: dev
Are you sure you want to change the base?
Conversation
Minimal change with a big effect. In German that results in: Create a new entity = Eine neue Entität erstellen Creates a new entity = Erstellt eine neue Entität Completely different meaning and completely different sentences in German.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
imho in English "creates" makes a confusion. |
@ildar170975 You have to look at the complete picture in the bug report:
Or in one sentence: "Create a new XYZ helper, which creates a new entity" With the current wording we have
which sounds like two unrelated processes performed in parallel. |
@NoRi2909 |
I don't think "creates" works as well as the current wording. |
@googanhiem Please have a look at the complete picture in the bug report. We currently have (headline plus explanation):
which sounds like two processes performed in parallel. This PR wants to change this to:
Or in one sentence: "Create a new XYZ helper, which creates a new entity" |
When there is no matching entity found for an action, the entity picker offers to create a new helper.
The subline is currently:
which should be an explanation instead:
Minimal change with a big effect. In German that results in:
Completely different meaning and completely different sentences in German.
Proposed change
Add the missing "s" to "Create".
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: