Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve readability of sentence_count check #2645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreasbrett
Copy link
Contributor

Improve readability of the difference in counted sentences (see #2630). Especially beneficial with larger numbers (compare 100000000 to 100,000,000). Also added relative difference in percent.

Before:

Counting previous sentences for language: en: 403495
Counting **NEW** sentences for language: en: 103495

New count: -300000

After:

Counting previous sentences for language: en: 403495
Counting **NEW** sentences for language: en: 103495

New count: -300,000 (-74%)

@balloob
Copy link
Member

balloob commented Nov 26, 2024

I temporarily removed the github action because it was causing a CI failure on some PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants