fix(chrome-extension): reorder code to maintain comments so that code strip will work #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strip will work Fixes: #1383
|
Integration tests are failing while installing Playwright browsers. I suspect this is a transient failure and it should be OK a bit later. |
stympy
previously approved these changes
Oct 12, 2024
|
After more investigation, it seems that we have to update Playwright because the version we were using is not available anymore. I will merge this PR and work on integration tests separately. |
This reverts commit 59bf14b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes: #1383.
Typescript would remove the comment
ROLLUP_STRIP_CODE_CHROME_EXTENSION_ENDwhen transpiling from .ts to .js because it was sitting alone and not connected to any function. I reordered the code and it seems to work now.