feat: OTLP bidirectional span links #167
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for bidirectional span links. Currently, a span link is a single direction only, and there is no context in Honeycomb that a span is being linked to. Since span links are just another event in Honeycomb, this will add an additional span link event swapping the trace fields and linked trace fields for the attributes.
Draft: Right now, this works based on the presence of a span link attribute, but that requires customers to add that attribute and does not work for situations where the span link is generated from auto-instrumented code. Before I write the unit tests for this, I would like to discuss if we use the special attribute or create the additional event all the time. I vote for always creating the additional event since this makes rolling out the functionality of bidirectional links automatic for all customers.