add support for gcp dataproc clusters #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmxs
reviewed
Jul 27, 2021
mhmxs
approved these changes
Jul 28, 2021
blentz
force-pushed
the
support_dataproc_clusters
branch
from
e762b83 to
6226acb
Compare
mhmxs
reviewed
Jan 5, 2022
Bump go version to 1.17 Introduce new resource type: storage Introduce new action: cleanup Introduce new env var configuration: RETENTION_DAYS Collect Azure storage accounts, filter its blob contents by creation date, and delete old blobs.
blentz
force-pushed
the
support_dataproc_clusters
branch
7 times, most recently
from
bca66de to
00d4a7b
Compare
|
@mhmxs Sorry for the delay in addressing the review comments. I believe I've fixed everything that was mentioned. :) |
blentz
force-pushed
the
support_dataproc_clusters
branch
from
00d4a7b to
8159869
Compare
|
@blentz Thank you. I think yes. so LGFM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding support for scanning GCP's Dataproc Clusters. [1]
This enables all of the filters that work for Instances to also work for dataproc Clusters.
[1] https://cloud.google.com/dataproc/