Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/live monitoring #6151

Closed
wants to merge 64 commits into from
Closed

Feature/live monitoring #6151

wants to merge 64 commits into from

Conversation

emi420
Copy link
Collaborator

@emi420 emi420 commented Dec 7, 2023

This PR adds a new view for live monitoring of mapping projects, providing data quality insights.

You can see how it looks here:

#6109 (comment)

There are some other tasks that needs to be completed in order to have this feature in production.

Bonkles and others added 26 commits September 25, 2023 12:02
@Bonkles @tsmock
Remove references to rapid context methods that no longer exist.
e7da777
@tsmock
Rapid v2: Show the GPX data
8c0e283 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Fix NPE in rapidEditor
d2212be 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid updates
e000b70 
Signed-off-by: Taylor Smock <[email protected]>
@Bonkles @tsmock
Bump rapid version to 2.0.3, also make use of imagery and init promis…
5fc041d 
…es to perform imagery switching at startup time. Also, rewrite history change to use URLSearchParams to replace existing Bing Param, if any.
@Bonkles @tsmock
Fix bug that would cause the 'custom editor' useEffect code to fire e…
e8e5031 
…ven though no custom imagery source was defined.
@tsmock
Update yarn.lock
8b014b1 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Update for next Rapid version
f392ca1 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Update Rapid to v2.1.1
3748ace 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Use system interface for setting up Rapid
99e2fe7 
Also, import Rapid from CDN instead of bundling it with the TM.
We still have to bundle the Rapid CSS file -- initial try on
importing the CSS file from the CDN failed. If that is fixed,
we could use a semver query for the CDN version, and get minor
Rapid updates for "free".

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Load css and data resources from CDN
4076030 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Fix issue where toggling sidebar would lose data, ensure mapvi…
369cbea 
…ew is resized

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Don't try to upload to sentry if we aren't logged in
8bc4c34 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Fix preauth
2853556 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Use URL hash parameters instead of function calls
8ccc027 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Get it working between task switches
46a7d83 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Store dom node in state for reuse
afbada4 
Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Rapid: Export functions that may be useful for iD and add basic tests…
3b54de2 
… for some of those functions

Signed-off-by: Taylor Smock <[email protected]>
@tsmock
Listen for reset events to update task state disable state
0a88b11 
Signed-off-by: Taylor Smock <[email protected]>
@royallsilwallz
Merge branch 'chore/update-rapid' of github.com:facebook/OSM-HOT-Task…
95417b3 
…ing-Manager into facebook/chore/update-rapid
@royallsilwallz
fix test case fail error
5475b68
@royallsilwallz
Merge branch 'develop' of github.com:hotosm/tasking-manager into develop
3420409
@royallsilwallz
Merge branch 'chore/update-rapid' of github.com:facebook/OSM-HOT-Task…
94524a2 
…ing-Manager into develop
@emi420
+ Add a new view for live quality monitoring
8c1de4b
@emi420
Add a TODO message for enable/disable live monitoring button
a69ab25
@emi420
Remove log message
4f574bb
@emi420 emi420 added the data-quality Issues related to data quality and validation workflow label Dec 7, 2023
@manjitapandey manjitapandey mentioned this pull request Jan 19, 2024
Closed
@royallsilwallz royallsilwallz mentioned this pull request Jan 26, 2024
Closed
@royallsilwallz
Copy link
Contributor

The build file of CSS has been changed from 452.4KB (develop branch) to 6.54MB (feature/liveMonitoring branch).

The size is coming from @hotosm/underpass-ui/dist/index.css (5.9MB). It has 336,016 lines of code, almost all coming from Tailwind CSS.

This requires optimization.
The solution would be to minify this file.
Also, see if there are unwanted codes in the dist files.

Were you aware of this, @emi420 ?

Screenshot

  • develop VS feature/liveMonitoring branch
    image

@emi420
Copy link
Collaborator Author

emi420 commented Feb 13, 2024

@royallsilwallz Underpass UI CSS is now optimized, size reduced to 10kb :)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
19 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@royallsilwallz
Copy link
Contributor

I can confirm that the size is optimized now. Nice work @emi420 !
I've upgraded the latest Underpass UI repo and pushed the code.
I think we should merge this now. What do you say ?
CC - @ramyaragupathy @manjitapandey

@ramyaragupathy
Copy link
Member

Since there are conflicts and merge that's unrelated to this PR which makes the conflict resolution difficult, we will have @emi420 create a separate branch.

Also, we will include this feature only in expert mode. Once the new PR is up from @emi420, @royallsilwallz will implement the changes to support the view for expert mode features

@ramyaragupathy ramyaragupathy mentioned this pull request Mar 19, 2024
Closed
@emi420
Copy link
Collaborator Author

emi420 commented Mar 21, 2024

Closing this PR because we'll create a new one.

@emi420 emi420 closed this Mar 21, 2024
@royallsilwallz royallsilwallz reopened this Apr 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@royallsilwallz
Copy link
Contributor

Continued with #6299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royallsilwallz royallsilwallz royallsilwallz approved these changes

@varun2948 varun2948 varun2948 approved these changes

@kaditya97 kaditya97 Awaiting requested review from kaditya97

Assignees

@varun2948 varun2948

Labels
data-quality Issues related to data quality and validation workflow dependencies Pull requests that update a dependency file scope: frontend scope: infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@emi420 @royallsilwallz @kshitijrajsharma @varun2948 @manjitapandey @ramyaragupathy @Bonkles @tsmock @mahesh-naxa