Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes support for generators as well as manifest and install tasks when working in a Rails engine. #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pbhogan
Copy link

@pbhogan pbhogan commented Sep 3, 2024

Addresses #138

  • app:stimulus:* tasks correctly run in test/dummy and put files in the right places.
  • stimulus:* tasks exist and put files under the engine namespace.
  • The stimulus controller generator, when run in the engine root, includes the engine namespace.
  • Namespaces are correctly handled in index.js and in terms of where files are placed.

Note: a small extension of Rake is included to make defining the top-level tasks possible.

…en working in a Rails engine.

app:stimulus:* tasks correctly run in test/dummy and put files in the right places.
stimulus:* tasks exist and puts files under the engine namespace.
The stimulus controller generator, when run in the engine root, includes the engine namespace.
Namespaces are correctly handled in index.js and in terms of where files are placed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant