Support for registering Strada components per web view #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers in the Turbo config.
joemasilotti
requested changes
Mar 5, 2024
| @@ -289,7 +289,9 @@ extension TurboNavigator { | |||
| guard let _ = session.activeVisitable?.visitableViewController, | |||
| let url = session.activeVisitable?.visitableURL else { return } | |||
|
|
|||
| let newSession = Session(webView: Turbo.config.makeWebView()) | |||
| let newSession = Session( | |||
| webView: Turbo.config.makeWebView(for: session == self.session ? .main : .modal) | |||
There was a problem hiding this comment.
Suggested change
| webView: Turbo.config.makeWebView(for: session == self.session ? .main : .modal) | |
| webView: Turbo.config.makeWebView(for: session === self.session ? .main : .modal) |
| @@ -19,7 +19,11 @@ public class TurboConfig { | |||
|
|
|||
| /// Optionally customize the web views used by each Turbo Session. | |||
| /// Ensure you return a new instance each time. | |||
| public var makeCustomWebView: WebViewBlock = { (configuration: WKWebViewConfiguration) in | |||
| public var mainWebViewProvider: WebViewBlock = { configuration in | |||
There was a problem hiding this comment.
I prefer to keep the old function and only add the two new ones. That gives developers a way to customize both at the same time, like in the Demo app, or dive into more specific customizations.
|
@joemasilotti, I discussed this PR with @jayohms, and we've decided to close it. This approach doesn't address one of our specific cases, and the default implementation should suffice for most users. We'll revisit the approach once we begin integrating TurboNavigator into our apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.