Remove disclaimer for data-turbo-method not working in forms
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Turbo handbook mentions that
data-turbo-methoddoes not work in forms as it generates a hidden form which is invalid HTML.While working on a separate Rails PR, I discovered that when the
data-turbo-methodattribute is present,turboactually appends the hidden form todocument.bodyinstead of nesting it in the parent form which makes it "work":https://github.com/hotwired/turbo/blob/main/src/observers/form_link_click_observer.ts#L63
It doesn't feel right to have a non-
GETlink in a form. But, I also think it makes sense to remove the disclaimer as it's not accurate.Please correct me or close this PR if I understood the
data-turbo-methodimplementation wrongly. Thank you!