Fix navigation to the turbo-root not using Turbo Drive #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afcapel @kevinmcconnell could we grant permission to execute CI on this branch? |
|
We need to fix the merge conflict before we can run CI. |
fritzmg
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
I can confirm the original issue and that this PR fixes it.
Any chance to get this merged and released?
|
See #1341 for an updated version without merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912 by simply not adding a trailing slash to the root URL prefix.
I'm not sure if this is the best way to fix this issue, but it makes the new test case pass and doesn't break any other tests.