Implement receiving of CAN messages via MQTT #1279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like it, it is elegant. Nice 💪 However, if it is really just for debugging or development, should we guard it with a #define? Unfortunately, transmitting this info to the web app will be cumbersome. @AndreasBoehm What do you think? Can this be a mainstream feature? I guess there should be a prominent warning that "this setting is probably not for you" (plus link to the docs)? |
|
What if we put it in the web app but don't include it in the navigation? EDIT: or we add a URL param |
This is mainly intended for debugging.
ranma
force-pushed
the
can-over-mqtt
branch
from
b6d8e50
to
4868df6
Compare
Changed the view so it only shows up with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly intended for debugging.